Skip to content

fix: Add SPAN_KIND_ values to service map filters#1513

Merged
kodiakhq[bot] merged 4 commits intomainfrom
drew/fix-service-map-span-kind-values
Dec 29, 2025
Merged

fix: Add SPAN_KIND_ values to service map filters#1513
kodiakhq[bot] merged 4 commits intomainfrom
drew/fix-service-map-span-kind-values

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Dec 22, 2025

Closes #1512
Closes HDX-3100

Summary

This PR adds additional valid server/client/producer/consumer span kind values to the service map query.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e706b85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Dec 29, 2025 3:54pm

@claude
Copy link

claude bot commented Dec 22, 2025 •
edited
Loading

Code Review

✅ No critical issues found.

The changes correctly add support for OpenTelemetry standard span kind values (SPAN_KIND_SERVER, SPAN_KIND_CLIENT, etc.) alongside the existing title-case values. This pattern is consistent with existing code in serviceDashboard.ts:190 and resolves the issue where service maps fail to display when using OTEL Collector data.

Verified:

  • Pattern matches existing codebase conventions (serviceDashboard.ts:190)
  • Includes all relevant span kinds (Server/Client, Consumer/Producer)
  • Maintains backward compatibility with title-case values
  • Changeset properly documented

Good fix! 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025 •
edited
Loading

E2E Test Results

✅ All tests passed • 51 passed • 4 skipped • 682s

Status Count
✅ Passed 51
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew requested review from a team and wrn14897 and removed request for a team December 29, 2025 12:04
@kodiakhq kodiakhq bot merged commit d5181b6 into main Dec 29, 2025
12 checks passed
@kodiakhq kodiakhq bot deleted the drew/fix-service-map-span-kind-values branch December 29, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhable dhable dhable approved these changes

@wrn14897 wrn14897 Awaiting requested review from wrn14897 wrn14897 was automatically assigned from hyperdxio/hyperdx-team

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Service Map Span Kind Expression not working in WHERE clause

2 participants

@pulpdrew @dhable